View Issue #7412 / Incorrect use of $pageSize parameter in Mage_Eav_M

Posted: 2008-09-27 07:52:44
Category: Product
Version: 1.1.6
Priority: normal
Status: closed
Reported By: Paryank Kansara

Well, I do not know weather it is a right place to submit the issues related to code or not because the Category fields contains the feature list not the module list and this issue is related to the code inside Mage_Eav module.

I recently seen the code of Mage_Eav_Model_Entity_Collection_Abstract class. There is a method setPage() defined inside it. This method contains two parameters: $pageNum and $pageSize. I guess that $pageSize is intended to set page size and page number in a single statement.

Here, $pageNum is passed to setCurPage() which is correct but $pageSize is passed to getPageSize() method which actully does not expect any argument but returns the page size. So the second parameter $pageSize remains unused.

I guess there should be setPageSize instead of getPageSize().

---